Github actions are failing

I am getting errors with the automated build and artifact push of the TDM analyzer GitHub - bitswype/saleae_tdm_analyer: TDM analyzer for Saleae logic 2 . When a new commit is made to the repo, I see the following failure:

Set up job

This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: Deprecation notice: v1 and v2 of the artifact actions - GitHub Changelog

I made sure I had the same build.yaml file as: SampleAnalyzer/.github/workflows/build.yml at master · saleae/SampleAnalyzer · GitHub

@chriskeeser You’re right. It looks like the auto-build is failing.

I’m not immediately sure what is causing the issue. I’ll schedule some time with the team here next week to see what’s going on and we’ll keep you updated on our findings.

Thanks for reporting this! I thought I had fixed this, but it turns out I had only updated our normal analyzer repos, and not our sample analyzer.

I’ve just updated our sample analyzer repository to use the newer v4 actions.

Any community analyzers using github actions will need to either pull in our changes, or just manually replace @v2 with @v4 in their .github\workflows\build.yml file.

In the meantime, if you find a community authored analyzer on github which has failing builds due to this issue, I would recommend:

  1. create an issue on the repository. (Feel free to link to this post)
  2. Fork, fix, and open a PR. (or let us know and we can do it)
  3. Use the build from your fixed fork in the short term.

You can also build community created analyzers locally, by following the instructions in the Sample Analyzer repository readme.

Thanks @timreyes and @markgarrison. I have updated the build.yaml and Linux / Windows are back to building. However, the Mac build is failing with:

ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Analyzers/libtdm_analyzer.so] Error 1

Before the update, the Mac builds were successful. Any insights you can provide?

I found the issue - we had updated another file in the SampleAnalyzer repo required for MacOS builds with both x86_64 support and arm64 support. I forked the repo and created a PR with the fix here:

Sorry for the trouble! Let me know if you need anything else.

1 Like

Wonderful, I have merged in the PR and everything is back to building. Thanks for taking the time to fix this.